Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Indexing and selecting data¶ #41645

Closed
wants to merge 2 commits into from

Conversation

rbrishabh
Copy link

fixes #41629

Hi @LukeTonin, how does this look?
let me know if this needs any changes!
Thanks

@attack68
Copy link
Contributor

Just commenting that medium.com is a paid article provider. That link is not always available, depending upon how many "free" articles you are permitted view in a period of time.

@pablodz
Copy link

pablodz commented May 24, 2021

Maybe can be added this https://stackoverflow.com/a/41130329/10491422 due it's a common limitation that causes confusion, instead of a medium blog

@rbrishabh
Copy link
Author

Sure! I can do that

@LukeTonin
Copy link

@rbrishabh That looks good. Agreed with the point about medium not always being accessible. A "free" resource would be better.

@rbrishabh
Copy link
Author

Thanks! @LukeTonin made that url change

@simonjayhawkins simonjayhawkins added Docs Indexing Related to indexing on series/frames, not to indexes themselves labels May 24, 2021
@jreback
Copy link
Contributor

jreback commented May 25, 2021

can u make this into a :note: to make this more prominent

text looks good

ping when greenish

@jreback jreback added this to the 1.3 milestone May 25, 2021
@mwaskom
Copy link
Contributor

mwaskom commented May 25, 2021

There is already a warning block with this information in the same section; wouldn't a note linking out to an external resource be redundant?

Also, after changing what the link goes to, the context ("10 reasons") no longer corresponds.

@jreback
Copy link
Contributor

jreback commented May 26, 2021

yeah i see this is already adequately documented: https://pandas.pydata.org/pandas-docs/dev/user_guide/indexing.html#attribute-access, thanks @mwaskom

thanks for the effort @rbrishabh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QST: difference using ['column'] or .column?
7 participants