PERF/REGR: revert #41785 #42338
Merged
PERF/REGR: revert #41785 #42338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jul 1, 2021
•
jbrockmendel
commented
- closes PERF: regression in DataFrame construction from nested dict #42248
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
added
Constructors
|
Thanks @jbrockmendel as this now goes in 1.3.1, will need a release note. |
#42312 now merged |
|
@jbrockmendel lgtm can you add a release note for 1.3.1 |
|
@meeseeksdev backport 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jul 8, 2021
|
Something went wrong ... Please have a look at my logs. |
simonjayhawkins
pushed a commit
that referenced
this pull request
Jul 8, 2021
Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
| @@ -16,6 +16,7 @@ Fixed regressions | |||
| ~~~~~~~~~~~~~~~~~ | |||
| - Pandas could not be built on PyPy (:issue:`42355`) | |||
| - :class:`DataFrame` constructed with with an older version of pandas could not be unpickled (:issue:`42345`) | |||
| - Performance regression in constructing a :class:`DataFrame` from a dictionary of dictionaries (:issue:`42338`) | |||
There was a problem hiding this comment.
thanks, will add this to my next "collected cleanups" branch
There was a problem hiding this comment.
would need to backport, but no worries if added with other changes since the release readiness script will show that the release notes aren't in sync and I will sync directly to 1.3.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.