BUG: dtype lost in DataFrame.append #43392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Sep 3, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
- For BlockManager, this improves dtype-retention, see test_append_same_columns_type
- For ArrayManager, this fixes an unwanted casting to object, see test_append_empty_frame_to_series_with_dateutil_tz
- I'm increasingly confident that with this, we can get rid of several kludges in internals.concat
- This does change the order of columns in some cases, see test_append_empty_frame_to_series_with_dateutil_tz. AFAICT this is due to a bug in union_indexes (but fixing it breaks other things that i need to run down), xref BUG: concat still sorts columns if they differ #43375
jreback
requested changes
Sep 4, 2021
| ) | ||
| # integer dtype is preserved for columns present in ser.index |
There was a problem hiding this comment.
assert_frame_equal compares these dtypes no? (i guess ok that you are being explicit as well)
|
whatsnew added + green |
jreback
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.