REG: Regression in explode when column is non string #43802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Regression
4 tasks
otherwise lgtm |
|
Now I rememeber why the assertion was there |
prob could add one for all scalar types |
|
thanks @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 30, 2021
|
@meeseeksdev backport 1.3.x |
|
Something went wrong ... Please have a look at my logs. |
|
Will do as a follow up |
phofl
added a commit
that referenced
this pull request
Sep 30, 2021
…ing (#43817) Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
| @@ -8201,7 +8201,7 @@ def stack(self, level: Level = -1, dropna: bool = True): | |||
|
|
|||
| def explode( | |||
| self, | |||
| column: str | tuple | list[str | tuple], | |||
| column: Scalar | tuple | list[Scalar | tuple], | |||
There was a problem hiding this comment.
we normally use Hashable for index labels. We also have the alias in pandas._typing IndexLabel = Union[Hashable, Sequence[Hashable]]
gasparitiago
pushed a commit
to gasparitiago/pandas
that referenced
this pull request
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFrame.explodeis failing on scalarintvalue. #43314This should cover the issue since the other pr did not make any progress.
Is there a fixture providing all scalar dtypes?