update fix ignored sort in api.py and add test #43833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @CloseChoice! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-10-08 14:56:28 UTC |
jreback
reviewed
Oct 1, 2021
| @@ -63,3 +63,13 @@ def test_concat_series_with_numpy(to_concat_dtypes, result_dtype): | |||
| result = pd.concat([s2, s1], ignore_index=True) | |||
| expected = pd.Series([0, 1, 0, 1, pd.NA], dtype=object).astype(result_dtype) | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_concat_frame_with_sort_false(): | |||
There was a problem hiding this comment.
can you move to pandas/tests/reshape/concat/test_sort.py
put near simliar tests
jreback
requested changes
Oct 1, 2021
Can we just adjust other test results? That would be technically be a breaking change, wouldn't it? |
|
my point about adjusting test is that this case might be only internal or not - will have to see |
|
@github-actions pre-commit |
jreback
requested changes
Oct 8, 2021
…-ignores-sort-param-43375
…eChoice/pandas into FIX-concat-ignores-sort-param-43375
|
@github-actions pre-commit |
|
@jreback all lights on green. I also added a whatsnew entry. |
jreback
approved these changes
Oct 10, 2021
|
thanks @CloseChoice |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the ticket, the function
api.union_indexesdoes not handle the sort parameter. I added support for it, but we explicitly check that sort can only take the valuesFalseandNonein here