Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: ‘names’ param in Index.copy #44916

Merged
merged 6 commits into from
Dec 16, 2021
Merged

DEPR: ‘names’ param in Index.copy #44916

merged 6 commits into from
Dec 16, 2021

Conversation

topper-123
Copy link
Contributor

Deprecates this parameter. names is not used in Index.__init__, so no reason to be used in Index.copy.

@topper-123 topper-123 changed the title DEPR: names param in Index.copy DEPR: ‘names’ param in Index.copy Dec 16, 2021
@jreback jreback added Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses labels Dec 16, 2021
@jreback jreback added this to the 1.4 milestone Dec 16, 2021
@jreback
Copy link
Contributor

jreback commented Dec 16, 2021

@jbrockmendel ok here?

@jreback jreback mentioned this pull request Dec 16, 2021
Closed
@jbrockmendel
Copy link
Member

No objections

@jreback jreback merged commit adfc78b into pandas-dev:master Dec 16, 2021
@jreback
Copy link
Contributor

jreback commented Dec 16, 2021

thanks @topper-123

@topper-123 topper-123 deleted the index_copy_names branch December 16, 2021 22:11
@jbrockmendel
Copy link
Member

@topper-123 shouldnt this be done in RangeIndex.copy too? should name be deprecated in MultiIndex.copy?

@jbrockmendel jbrockmendel mentioned this pull request Dec 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@topper-123 @jreback @jbrockmendel