CLN: remove _from_mgr (no longer used after GH-45363) #45415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -285,22 +285,6 @@ def _init_mgr( | |||
| mgr = mgr.astype(dtype=dtype) | |||
| return mgr | |||
|
|
|||
| @classmethod | |||
| def _from_mgr(cls, mgr: Manager): | |||
There was a problem hiding this comment.
Removed this, because it was only used in the groupby Splitter (and so that usage was removed in the previous PR)
|
we just merged some cleanup similar to this by @jbrockmendel so if you can rebase |
|
@jbrockmendel it would be useful if you can mention the PR when doing a follow-up to a specific PR (so that github shows it as a linked PR in the original PR) |
jorisvandenbossche
changed the title
|
thanks @jorisvandenbossche |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One part of the follow-up to #45363
This one doesn't necessarily need to be backported to 1.4