Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: allow DBAPI2 object #45416 #45496

Merged
merged 1 commit into from
Jan 20, 2022
Merged

BUG: allow DBAPI2 object #45416 #45496

merged 1 commit into from
Jan 20, 2022

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Jan 20, 2022 •
edited
Loading

@fangchenli fangchenli added this to the 1.4 milestone Jan 20, 2022
@fangchenli fangchenli added IO SQL to_sql, read_sql, read_sql_query Regression Functionality that used to work in a prior pandas version labels Jan 20, 2022
@jreback jreback merged commit 3418679 into pandas-dev:main Jan 20, 2022
@jreback
Copy link
Contributor

jreback commented Jan 20, 2022

thanks @fangchenli

@jreback
Copy link
Contributor

jreback commented Jan 20, 2022

@meeseeksdev backport 1.4.x

@meeseeksmachine meeseeksmachine mentioned this pull request Jan 20, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 20, 2022
@fangchenli @meeseeksmachine
Backport PR pandas-dev#45496: BUG: allow DBAPI2 object pandas-dev#45416
52fb784
@lumberbot-app
Copy link

lumberbot-app bot commented Jan 20, 2022

Something went wrong ... Please have a look at my logs.

@simonjayhawkins
Copy link
Member

Thanks @fangchenli

@fangchenli fangchenli deleted the allow-dbapi-conn branch January 20, 2022 18:40
jreback pushed a commit that referenced this pull request Jan 20, 2022
@meeseeksmachine @fangchenli
Backport PR #45496: BUG: allow DBAPI2 object #45416 (#45502)
6bbf454 
Co-authored-by: Fangchen Li <fangchen.li@outlook.com>
@abowden1989 abowden1989 mentioned this pull request Jan 28, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

REGR: 1.4.0rc0: pd.read_sql not compatible with pymysql
3 participants
@fangchenli @jreback @simonjayhawkins