Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: fix URLs, formatting and typos #45920

Merged
merged 9 commits into from
Feb 11, 2022
Merged

DOC: fix URLs, formatting and typos #45920

merged 9 commits into from
Feb 11, 2022

Conversation

partev
Copy link
Contributor

@partev partev commented Feb 10, 2022

"## Development tools" is not formatted correctly here: https://pandas.pydata.org/community/ecosystem.html
Screenshot 2022-02-10 10 22 42

partev added 4 commits February 9, 2022 23:27
@partev
DOC: fix a typo
f1c2c2a 
all other plotting functions refer to :meth:`DataFrame.plot`. for **kwargs
@partev
DOC: fix incorrect documentation
99979ed 
first_valid_index() returns None if no non-NA values are found.
@partev
fix URL redirect
52451aa 
http://www.cython.org/ -> https://cython.org
@partev
fix formatting
2fbfc7e
MarcoGorelli
MarcoGorelli approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @partev - btw, if you have many more changes like these, it's OK to group them together into the same PR

@attack68
Copy link
Contributor

attack68 commented Feb 10, 2022 •
edited
Loading

Thanks @partev - btw, if you have many more changes like these, it's OK to group them together into the same PR

yes, please don't fill up the PRs with a number of one line typos fixes.

It is probably better to close the other PRs and include them all here. Thx

@partev
Copy link
Contributor Author

partev commented Feb 10, 2022

Thanks @partev - btw, if you have many more changes like these, it's OK to group them together into the same PR

yes, please don't fill up the PRs with a number of one line typos fixes.

It is probably better to close the other PRs and include them all here. Thx

ok, I will combine them here.

@partev partev marked this pull request as draft February 10, 2022 19:35
@partev partev requested a review from MarcoGorelli February 10, 2022 20:16
@partev partev marked this pull request as ready for review February 10, 2022 20:17
@partev partev changed the title fix formatting DOC: fix URLs, formatting and typos Feb 10, 2022
@mroeschke mroeschke added the Docs label Feb 10, 2022
@mroeschke mroeschke added this to the 1.5 milestone Feb 10, 2022
@jreback jreback modified the milestones: 1.5, 1.4.1 Feb 11, 2022
@jreback jreback merged commit 1b5338e into pandas-dev:main Feb 11, 2022
@jreback
Copy link
Contributor

jreback commented Feb 11, 2022

thanks @partev

@jreback
Copy link
Contributor

jreback commented Feb 11, 2022

@meeseeksdev backport 1.4.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 11, 2022
@partev @meeseeksmachine
Backport PR pandas-dev#45920: DOC: fix URLs, formatting and typos
3b963af
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 11, 2022
Merged
@lumberbot-app
Copy link

lumberbot-app bot commented Feb 11, 2022

Something went wrong ... Please have a look at my logs.

@partev partev deleted the patch-11 branch February 11, 2022 02:37
simonjayhawkins pushed a commit that referenced this pull request Feb 11, 2022
@meeseeksmachine @partev
Backport PR #45920: DOC: fix URLs, formatting and typos (#45930)
0fc655f 
Co-authored-by: partev <petrosyan@gmail.com>
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
@partev @phofl
DOC: fix URLs, formatting and typos (pandas-dev#45920)
13dbf33
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@partev @yehoshuadimarsky
DOC: fix URLs, formatting and typos (pandas-dev#45920)
36e101a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@partev @attack68 @jreback @MarcoGorelli @mroeschke