CLN: Remove unused and undocumented kind keyword from read_excel #4713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe kind was meant to be engine/flavor at some point to support different backends |
|
I think it might have been for xlsx/xls. For now, it's just weird to have something in the function signature that's |
|
@jreback and others - any objections to merging this? |
Pops kwarg and warns if you pass it (rather than passing on)
|
looks good |
jtratner
added a commit
that referenced
this pull request
Sep 1, 2013
CLN: Remove unused and undocumented kind keyword from read_excel
This was referenced Apr 3, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pops kwarg and warns if you pass it (rather than passing on).
Fixes #4712