Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS: Bump Cython #47150

Merged
merged 3 commits into from
May 27, 2022
Merged

DEPS: Bump Cython #47150

merged 3 commits into from
May 27, 2022

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented May 27, 2022

Remember to also merge MacPython/pandas-wheels#181 too (I would recommend against merging this if you don't have write perms there as well, as we merge these too at the same time ideally).

@lithomas1 lithomas1 added this to the 1.4.3 milestone May 27, 2022
@lithomas1 lithomas1 added CI Continuous Integration Dependencies Required and optional dependencies labels May 27, 2022
@jreback jreback merged commit 3a7eed3 into pandas-dev:main May 27, 2022
@jreback
Copy link
Contributor

jreback commented May 27, 2022

thanks @lithomas1

@jreback
Copy link
Contributor

jreback commented May 27, 2022

@meeseeksdev backport 1.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented May 27, 2022

Could not push to auto-backport-of-pr-47150-on-1.4.x due to error, aborting.

@simonjayhawkins
Copy link
Member

Remember to also merge MacPython/pandas-wheels#181 too (I would recommend against merging this if you don't have write perms there as well, as we merge these too at the same time ideally).

do we need to update the pandas-feedstock for the conda packages? conda-forge/pandas-feedstock#134 recently updated cython >=0.29.16 to cython >=0.29.24,<3

@simonjayhawkins
Copy link
Member

Remember to also merge MacPython/pandas-wheels#181 too

that PR closed #41935

test_read_csv_and_table_sys_setprofile is still skipped?

simonjayhawkins added a commit that referenced this pull request May 28, 2022
* Backport PR #47150: DEPS: Bump Cython

* cython==0.29.30 in ci/deps/actions-310-numpydev.yaml

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
@lithomas1 lithomas1 deleted the bump-cython branch May 28, 2022 14:13
@lithomas1
Copy link
Member Author

lithomas1 commented May 28, 2022

do we need to update the pandas-feedstock for the conda packages? conda-forge/pandas-feedstock#134 recently updated cython >=0.29.16 to cython >=0.29.24,<3

This should be done whenever 1.4.3 comes out.

test_read_csv_and_table_sys_setprofile is still skipped?

Thanks for the reminder, will update.

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants