REGR: midx.values resetting freq of underyling index #49080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Regression
mroeschke
reviewed
Oct 14, 2022
| if isinstance(vals, ABCDatetimeIndex): | ||
| is_dti = isinstance(vals, ABCDatetimeIndex) | ||
|
|
||
| if is_dti: |
There was a problem hiding this comment.
Did the same thing happen to TimedeltaIndex?
There was a problem hiding this comment.
No, the underlying TimeDelta objects don't have the freq, so as type(object) a couple of lines below this return the correct objects without resetting the freq
mroeschke
approved these changes
Oct 14, 2022
|
Thanks @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 14, 2022
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.We can not reset the freq with a shallow copy, since the freq is an attribute of the underlying DatetimeArray. A deep copy would cost performance, but calling take before converting to object nicely solves this issue.