BUG: non-64-bit numeric dtypes should raise in IntervalDtype constructor #51322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
non_64_bit_numeric_dtypes_for_IntervalDtype
branch
from
2816531 to
1df0f0f
Compare
|
Ping. @jbrockmendel, could you take a look? |
simonjayhawkins
added
Bug
Dtype Conversions
| @@ -1132,6 +1134,12 @@ def __new__(cls, subtype=None, closed: str_type | None = None): | |||
| "for IntervalDtype" | |||
| ) | |||
| raise TypeError(msg) | |||
| elif is_any_real_numeric_dtype(subtype) and not is_64bit_real_numeric_dtype( | |||
There was a problem hiding this comment.
wont this allow through e.g. Int64 that we don't want? this seems a lot heavier than just checking itemsize
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Looks like this has gone stale. Feel free to reopen if/when you're interested in picking this back up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.