Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: describe not returning ArrowDtype #52470

Merged
merged 3 commits into from
Apr 6, 2023
Merged

BUG: describe not returning ArrowDtype #52470

merged 3 commits into from
Apr 6, 2023

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added Dtype Conversions Unexpected or buggy dtype conversions Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Arrow pyarrow functionality labels Apr 5, 2023
phofl
phofl approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, otherwise lgtm

pandas/tests/extension/test_arrow.py

@pytest.mark.parametrize("pa_type", tm.ALL_INT_PYARROW_DTYPES + tm.FLOAT_PYARROW_DTYPES)
def test_describe_numeric_data(pa_type):
data = pd.Series([1, 2, 3], dtype=ArrowDtype(pa_type))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add gh ref?

@phofl phofl merged commit 4d64a8a into pandas-dev:main Apr 6, 2023
@phofl phofl added this to the 2.0.1 milestone Apr 6, 2023
@phofl
Copy link
Member

phofl commented Apr 6, 2023

@meeseeksdev backport 2.0.x

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 6, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 4d64a8a057117a8b63d502e8da934a148af489cd
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #52470: BUG: describe not returning ArrowDtype'
  1. Push to a named branch:
git push YOURFORK 2.0.x:auto-backport-of-pr-52470-on-2.0.x
  1. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #52470 on branch 2.0.x (BUG: describe not returning ArrowDtype)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

topper-123 pushed a commit to topper-123/pandas that referenced this pull request Apr 6, 2023
@mroeschke @topper-123
BUG: describe not returning ArrowDtype (pandas-dev#52470)
7833cd2
@mroeschke mroeschke deleted the bug/describe/arrow_return branch April 6, 2023 18:41
mroeschke added a commit to mroeschke/pandas that referenced this pull request Apr 6, 2023
@mroeschke
Backport PR pandas-dev#52470: BUG: describe not returning ArrowDtype
6e66077
mroeschke added a commit that referenced this pull request Apr 6, 2023
@mroeschke
Backport PR #52470 on branch 2.0.x (BUG: describe not returning Arrow…
00a825f 
…Dtype) (#52495)

Backport PR #52470: BUG: describe not returning ArrowDtype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Arrow pyarrow functionality Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

BUG: describe with double[pyarrow] does not return pyarrow backed series.
2 participants
@mroeschke @phofl