Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #54737 on branch 2.1.x (MAINT: small simplification of meson.build following best practices) #54799

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Backport PR #54737 on branch 2.1.x (MAINT: small simplification of meson.build following best practices) #54799

merged 2 commits into from
Aug 28, 2023

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #54737: MAINT: small simplification of meson.build following best practices

@lumberbot-app lumberbot-app bot added this to the 2.1 milestone Aug 28, 2023
@lumberbot-app lumberbot-app bot added the Build Library building on various platforms label Aug 28, 2023
phofl
phofl requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't merge this, this breaks the windows builds

@phofl phofl merged commit 4855f54 into pandas-dev:2.1.x Aug 28, 2023
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl requested changes

@WillAyd WillAyd Awaiting requested review from WillAyd WillAyd is a code owner

Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@meeseeksmachine @phofl @dnicolodi