-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix : #58748 BUG: eval fails for ExtensionArray #58793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you consider adding a test ? maybe based on the example I provided ?
it may be located in pandas\tests\extension\test_datetime.py
Hey @mutricyl thanks for mentioning it, I have worked on it and did the necessary changes. Let me know if any other changes need to be made I will work on it. Thanks |
Thanks @rhshadrach @mutricyl I will work on this and update the PR as well |
Although, I tried making necessary changes, and I run the pre-commits as well didn't faced any issues in it but while doing here some checks are failing any guidance how can I move forward to this? |
@rhshadrach @mutricyl pushed one more PR, I fixed the issues, sorry from my end once again. Let me know if this works perfectly. Once again thanks for the help. |
Hey @rhshadrach @mutricyl just a follow up message that could you check the PR that I have pushed a while ago I hope this works for your guys do check and let me know if any more changes are required to be done from my end as well. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - can you add a line in the whatsnew for 3.0 in the Other
section. That section mentions not to use it, but I believe this case to be appropriate.
@rhshadrach updated the docs and committed the changes do check the PR and let me know if this works, Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @SiddheshBangar |
Welcome, thanks for helping and the guidance @rhshadrach, @mutricyl |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.