Upload 3.13 & free-threaded nightly wheels #59136

lysnikolaou · 2024-06-28T09:10:45Z

x-ref ENH: Python 3.13 free-threading support #59057

.github/workflows/wheels.yml

xbit18 · 2024-07-04T18:21:07Z

Hi, any progress on this?

lysnikolaou · 2024-07-11T15:46:49Z

Folks, I'm sorry for the multiple commits. I had to try things out before I get this right.

This is now ready for review. CircleCI is failing, but it does so on main as well.

xbit18 · 2024-07-11T16:16:43Z

Is there by chance a way to test the wheels?

lysnikolaou · 2024-07-12T12:02:51Z

Is there by chance a way to test the wheels?

The wheels are installed in a virtual environment and tests are run against them after creation. If you want to test locally, you can download the wheels from the build artifacts.

lysnikolaou · 2024-07-19T09:38:29Z

Ping. This is ready for review.

.github/workflows/wheels.yml

… matrix

lysnikolaou · 2024-07-19T22:14:18Z

@mroeschke Thanks for the review! Feedback addressed.

mroeschke · 2024-07-22T18:01:57Z

.github/workflows/wheels.yml

@@ -153,6 +163,7 @@ jobs:
        env:
          CIBW_PRERELEASE_PYTHONS: True
          CIBW_BUILD: ${{ matrix.python[0] }}-${{ matrix.buildplat[1] }}
+          CIBW_BUILD_FRONTEND: ${{ matrix.cibw_build_frontend || 'pip' }}


Looks like the wasm build needs to specify cibw_build_frontendas something based on the failing build

Hmm, according to the docs pyodide should ignore this setting, since only "build" is supported.

mroeschke · 2024-07-22T20:26:51Z

Thanks @lysnikolaou

EwoutH · 2024-07-23T04:55:50Z

Awesome!

Can we expect Python 3.13 support on the Pandas 2.x series, or will it be exclusive to 3.0?

mroeschke · 2024-07-23T16:31:11Z

Exclusive to 3.0

neutrinoceros · 2024-09-16T07:26:35Z

Hi. There seems to be no cp313 nightly available at the moment, when there were a couple days ago. Is it expected ?

jorisvandenbossche · 2024-09-16T12:53:32Z

Yes, see #59817, hopefully fixed by tomorrow!

jorisvandenbossche · 2024-09-18T16:42:16Z

@meeseeksdev backport to 2.2.x

lumberbot-app · 2024-09-18T16:42:40Z

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

git checkout 2.2.x
git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 7c0ee27e6c00e9645154583917de0f385190d8d8

You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #59136: Upload 3.13 & free-threaded nightly wheels'

Push to a named branch:

git push YOURFORK 2.2.x:auto-backport-of-pr-59136-on-2.2.x

Create a PR against branch 2.2.x, I would have named this PR:

"Backport PR #59136 on branch 2.2.x (Upload 3.13 & free-threaded nightly wheels)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

* Upload free-threaded nightly wheels on Linux and macOS * Consolidate jobs into one * Install build dependencies in before-build and pass --no-build-isolation * Fix {project} placeholder in cibuildwheel config * Correctly quote echo CIBW_BUILD_FRONTEND command * Run echo -e * Add {package} to before-build * Include cibw script in sdist & add matrix value for build frontend * Change manifest and gitattributes * Change gitattributes * Install verioneer in before-build * Add cibw_before_test to install nightly NumPy * Expand before-test to musl * Better comments plus always run before-build/before-test on 3.13 * Add --no-build-isolation in 3.13 as well * Install nightly numpy before windows tests * Address feedback; add todo for NumPy nightly and move default outside matrix * Set build_frontend to 'build' in pyodide build --------- Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> (cherry picked from commit 7c0ee27)

jorisvandenbossche · 2024-09-18T16:54:12Z

Backported in #59835

…ly wheels) (#59835) * Bump pypa/cibuildwheel from 2.19.1 to 2.19.2 (#59208) Bumps [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) from 2.19.1 to 2.19.2. - [Release notes](https://github.com/pypa/cibuildwheel/releases) - [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md) - [Commits](pypa/cibuildwheel@v2.19.1...v2.19.2) --- updated-dependencies: - dependency-name: pypa/cibuildwheel dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit ad09dc6) * Upload 3.13 & free-threaded nightly wheels (#59136) * Upload free-threaded nightly wheels on Linux and macOS * Consolidate jobs into one * Install build dependencies in before-build and pass --no-build-isolation * Fix {project} placeholder in cibuildwheel config * Correctly quote echo CIBW_BUILD_FRONTEND command * Run echo -e * Add {package} to before-build * Include cibw script in sdist & add matrix value for build frontend * Change manifest and gitattributes * Change gitattributes * Install verioneer in before-build * Add cibw_before_test to install nightly NumPy * Expand before-test to musl * Better comments plus always run before-build/before-test on 3.13 * Add --no-build-isolation in 3.13 as well * Install nightly numpy before windows tests * Address feedback; add todo for NumPy nightly and move default outside matrix * Set build_frontend to 'build' in pyodide build --------- Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> (cherry picked from commit 7c0ee27) * CI: Update to cibuildwheel 2.20.0 (#59401) cibuildwheel 2.20.0 uses the ABI stable Python 3.13.0rc1 and build Python 3.13 wheels by default, which allows removing the `CIBW_PRERELEASE_PYTHONS` flag. Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> (cherry picked from commit 70bb855) * Update wheels.yml * BLD/RLS: build wheels with released numpy/cython for Python 3.13 (#59819) (cherry picked from commit 2237217) * enable prerelease again --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com> Co-authored-by: Ewout ter Hoeven <E.M.terHoeven@student.tudelft.nl> Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>

Upload free-threaded nightly wheels on Linux and macOS

4371054

lysnikolaou requested a review from mroeschke as a code owner June 28, 2024 09:10

mroeschke reviewed Jun 28, 2024

View reviewed changes

.github/workflows/wheels.yml Outdated Show resolved Hide resolved

mroeschke added the CI Continuous Integration label Jun 28, 2024

Consolidate jobs into one

2cb8bbc

lysnikolaou mentioned this pull request Jul 2, 2024

Build 3.13 wheels #59134

Closed

lysnikolaou changed the title ~~Upload free-threaded nightly wheels on Linux and macOS~~ Upload 3.13 & free-threaded nightly wheels Jul 2, 2024

lithomas1 added the Build Library building on various platforms label Jul 5, 2024

Install build dependencies in before-build and pass --no-build-isolation

5f54ed7

lysnikolaou force-pushed the free-threaded-wheels branch from 32cdea9 to 04967eb Compare July 10, 2024 16:48

Fix {project} placeholder in cibuildwheel config

8bee350

lysnikolaou force-pushed the free-threaded-wheels branch from 04967eb to 8bee350 Compare July 10, 2024 17:27

lysnikolaou added 3 commits July 10, 2024 19:41

Correctly quote echo CIBW_BUILD_FRONTEND command

0a842b2

Run echo -e

c2bbdcb

Add {package} to before-build

7e87966

lysnikolaou force-pushed the free-threaded-wheels branch from 8aa6df5 to e16f34c Compare July 11, 2024 09:08

Include cibw script in sdist & add matrix value for build frontend

c36d905

lysnikolaou force-pushed the free-threaded-wheels branch from e16f34c to c36d905 Compare July 11, 2024 09:08

lysnikolaou added 8 commits July 11, 2024 11:51

Change manifest and gitattributes

f11120d

Change gitattributes

0b70025

Install verioneer in before-build

812527e

Add cibw_before_test to install nightly NumPy

e46055a

Expand before-test to musl

c487998

Better comments plus always run before-build/before-test on 3.13

2258d64

Add --no-build-isolation in 3.13 as well

0c4753a

Install nightly numpy before windows tests

15d0c8d

Merge branch 'main' into free-threaded-wheels

edcbf3c

mroeschke reviewed Jul 19, 2024

View reviewed changes

.github/workflows/wheels.yml Outdated Show resolved Hide resolved

mroeschke reviewed Jul 19, 2024

View reviewed changes

.github/workflows/wheels.yml Show resolved Hide resolved

Address feedback; add todo for NumPy nightly and move default outside…

2397f4c

… matrix

Merge branch 'main' into free-threaded-wheels

06b6ca1

mroeschke reviewed Jul 22, 2024

View reviewed changes

Set build_frontend to 'build' in pyodide build

778a60a

mroeschke approved these changes Jul 22, 2024

View reviewed changes

mroeschke added this to the 3.0 milestone Jul 22, 2024

mroeschke merged commit 7c0ee27 into pandas-dev:main Jul 22, 2024
88 of 91 checks passed

lysnikolaou mentioned this pull request Jul 24, 2024

ENH: Python 3.13 free-threading support #59057

Open

7 tasks

jorisvandenbossche mentioned this pull request Sep 16, 2024

BLD/RLS: build wheels with released numpy/cython for Python 3.13 #59819

Merged

jorisvandenbossche mentioned this pull request Sep 18, 2024

RLS: 2.2.3 #58354

Closed

jorisvandenbossche modified the milestones: 3.0, 2.2.3 Sep 18, 2024

lumberbot-app bot added the Still Needs Manual Backport label Sep 18, 2024

jorisvandenbossche mentioned this pull request Sep 18, 2024

Backport PR #59136 on branch 2.2.x (Upload 3.13 & free-threaded nightly wheels) #59835

Merged

jorisvandenbossche removed the Still Needs Manual Backport label Sep 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upload 3.13 & free-threaded nightly wheels #59136

Upload 3.13 & free-threaded nightly wheels #59136

lysnikolaou commented Jun 28, 2024

xbit18 commented Jul 4, 2024

lysnikolaou commented Jul 11, 2024

xbit18 commented Jul 11, 2024

lysnikolaou commented Jul 12, 2024

lysnikolaou commented Jul 19, 2024

lysnikolaou commented Jul 19, 2024

mroeschke Jul 22, 2024

lysnikolaou Jul 22, 2024

mroeschke commented Jul 22, 2024

EwoutH commented Jul 23, 2024

mroeschke commented Jul 23, 2024

neutrinoceros commented Sep 16, 2024

jorisvandenbossche commented Sep 16, 2024

jorisvandenbossche commented Sep 18, 2024

lumberbot-app bot commented Sep 18, 2024

jorisvandenbossche commented Sep 18, 2024

Upload 3.13 & free-threaded nightly wheels #59136

Upload 3.13 & free-threaded nightly wheels #59136

Conversation

lysnikolaou commented Jun 28, 2024

xbit18 commented Jul 4, 2024

lysnikolaou commented Jul 11, 2024

xbit18 commented Jul 11, 2024

lysnikolaou commented Jul 12, 2024

lysnikolaou commented Jul 19, 2024

lysnikolaou commented Jul 19, 2024

mroeschke Jul 22, 2024

Choose a reason for hiding this comment

lysnikolaou Jul 22, 2024

Choose a reason for hiding this comment

mroeschke commented Jul 22, 2024

EwoutH commented Jul 23, 2024

mroeschke commented Jul 23, 2024

neutrinoceros commented Sep 16, 2024

jorisvandenbossche commented Sep 16, 2024

jorisvandenbossche commented Sep 18, 2024

lumberbot-app bot commented Sep 18, 2024

jorisvandenbossche commented Sep 18, 2024