DOC: Add docstrings to fixtures in /series/methods/test_drop_duplicates.py #59265
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivonastojanovic
changed the title
ivonastojanovic
changed the title
ivonastojanovic
force-pushed
the
methods_test_drop_duplicates_fixture_docs
branch
from
27f6cfb
to
6427808
Compare
mroeschke
reviewed
Jul 17, 2024
| @@ -75,10 +75,22 @@ class TestSeriesDropDuplicates: | |||
| params=["int_", "uint", "float64", "str_", "timedelta64[h]", "datetime64[D]"] | |||
| ) | |||
| def dtype(self, request): | |||
| """ | |||
| Fixture that provides different data types for testing. | |||
There was a problem hiding this comment.
Could you ensure these docstrings just fit on one line?
There was a problem hiding this comment.
Do you mean to write a shorter description or the same description in just one line?
There was a problem hiding this comment.
Both I would say. These docstrings aren't entirely critical so it's best to be succinct.
mroeschke
approved these changes
Jul 18, 2024
|
Thanks @ivonastojanovic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docstrings to fixtures in
/pandas/tests/series/methods/test_drop_duplicates.pyfile.Partially addresses #19159