Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF (string dtype): de-duplicate _str_map (2) #59451

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

jbrockmendel
Copy link
Member

Follows #59443.

For the non-arrow version this is logic-neutral. For the arrow version the addition of L377-379 is a small change. It was introduced in #55736 for the non-arrow version and there is no indication the divergence was intentional.

@mroeschke mroeschke added Strings String extension data type and string data Refactor Internal refactoring of code labels Aug 8, 2024
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup

@jorisvandenbossche jorisvandenbossche changed the title REF (string): de-duplicate _str_map (2) REF (string dtype): de-duplicate _str_map (2) Aug 9, 2024
@mroeschke mroeschke added this to the 3.0 milestone Aug 9, 2024
@mroeschke mroeschke merged commit 3a7d82d into pandas-dev:main Aug 9, 2024
53 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-str_map-3 branch August 9, 2024 18:05
WillAyd pushed a commit that referenced this pull request Aug 13, 2024
* REF (string): de-duplicate _str_map (2)

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 14, 2024
* REF (string): de-duplicate _str_map (2)

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 15, 2024
* REF (string): de-duplicate _str_map (2)

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 15, 2024
* REF (string): de-duplicate _str_map (2)

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 15, 2024
* REF (string): de-duplicate _str_map (2)

* mypy fixup
@jorisvandenbossche jorisvandenbossche modified the milestones: 3.0, 2.3 Aug 20, 2024
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 21, 2024
* REF (string): de-duplicate _str_map (2)

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024
* REF (string): de-duplicate _str_map (2)

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024
* REF (string): de-duplicate _str_map (2)

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024
* REF (string): de-duplicate _str_map (2)

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 27, 2024
* REF (string): de-duplicate _str_map (2)

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Sep 20, 2024
* REF (string): de-duplicate _str_map (2)

* mypy fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants