TST (string dtype): fix IO dtype_backend tests for storage of str dtype of columns' Index #59509
+21
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+473
to
+478
| expected = DataFrame( | ||
| { | ||
| "a": pd.array(["a", "b"], dtype=pd.StringDtype(string_storage)), | ||
| "b": pd.array(["x", pd.NA], dtype=pd.StringDtype(string_storage)), | ||
| }, | ||
| ) |
There was a problem hiding this comment.
What this is changing is that the expected result is also created in the with pd.option_context("mode.string_storage", string_storage): context. What this actually changes is that when future.infer_string is enabled, that affects the storage used by the Index object with str dtype used for the columns of the resulting dataframe.
jorisvandenbossche
changed the title
Comment on lines
-715
to
+717
| tm.assert_frame_equal(result, expected) | ||
| # the storage of the str columns' Index is also affected by the | ||
| # string_storage setting -> ignore that for checking the result | ||
| tm.assert_frame_equal(result, expected, check_column_type=False) |
There was a problem hiding this comment.
This changes the tests to essentially just ignore the issue.
We could also verify it explicitly (although it's not the main thing that this test is meant to test) by doing something like:
if using_infer_string:
expected.columns = expected.columns.astype(pd.StringDtype(string_storage, na_value=np.nan))Which, now I comment that here, is maybe also perfectly fine (not too verbose, compared to the comment I had to add :))
mroeschke
approved these changes
Aug 14, 2024
|
Thanks @jorisvandenbossche |
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…pe of columns' Index (pandas-dev#59509) * TST (string dtype): fix failure in csv test_dtype_backend_string test * ignore storage of Index str dtype
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…pe of columns' Index (pandas-dev#59509)
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…pe of columns' Index (pandas-dev#59509)
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…pe of columns' Index (pandas-dev#59509)
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Aug 27, 2024
…pe of columns' Index (pandas-dev#59509)
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Sep 20, 2024
…pe of columns' Index (pandas-dev#59509)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick follow-up on #59481 (I missed that with the last merge of main there was actually one relevant failure, maybe some interaction with one of my other merged PRs)
This was caused because of the merge of #59488, that changed to honor the
mode.string_storageoption for the future default string dtype. That meant that DataFrames with string column names that were created in awith pd.option_context("mode.string_storage", string_storage):context would now also follow the specified storage for the column names.