Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix greedy date parsing in read_html #7851

Merged
merged 1 commit into from
Jul 28, 2014
Merged

BUG: fix greedy date parsing in read_html #7851

merged 1 commit into from
Jul 28, 2014

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 26, 2014

Also, infer_types now has no effect for real :)

closes #7762
closes #7032

@cpcloud cpcloud added this to the 0.15.0 milestone Jul 26, 2014
@cpcloud cpcloud self-assigned this Jul 26, 2014
@danielballan
Copy link
Contributor

Weird that Travis failed again. The file is says it can't find sure seems to be there....

@cpcloud
Copy link
Member Author

cpcloud commented Jul 27, 2014

Yeah not totally sure what happened. I'm gonna take a look tokorrow morning. I tried to reproduce but I had to move on to other things today.

@cpcloud
Copy link
Member Author

cpcloud commented Jul 27, 2014

Ah, I think this is because I forgot to add it to the data files in setup.py. I'll just rename to *.html, that way it gets picked up

@cpcloud
Copy link
Member Author

cpcloud commented Jul 27, 2014

@jreback @danielballan any (more) comments?

@cpcloud
Copy link
Member Author

cpcloud commented Jul 27, 2014

i'll add a release note

Necessitates the deprecation of the ``infer_types`` argument.
@cpcloud
Copy link
Member Author

cpcloud commented Jul 27, 2014

cc @clarkfitzg

@danielballan
Copy link
Contributor

Looks ready to merge to me. I didn't know about kwargs.setdefault; that's nice.

@jreback
Copy link
Contributor

jreback commented Jul 28, 2014

looks ok

@cpcloud
Copy link
Member Author

cpcloud commented Jul 28, 2014

Merging

cpcloud added a commit that referenced this pull request Jul 28, 2014
BUG: fix greedy date parsing in read_html
@cpcloud cpcloud merged commit 90fa87e into pandas-dev:master Jul 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Bug Deprecate Functionality to remove in pandas IO HTML read_html, to_html, Styler.apply, Styler.applymap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_html doesn't work for wikipedia tables read_html infers wrong datatype
3 participants