BUG: various categorical fixes (GH8626) #8652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| lambda x: x.astype('object').astype('category'), | ||
| lambda x: x.astype('object').astype(com.CategoricalDtype()), | ||
| lambda x: x.astype(pd.Categorical), | ||
| lambda x: x.astype('object').astype(pd.Categorical)]: |
There was a problem hiding this comment.
Is it actually needed that we support this? Should't it rather raise?
There was a problem hiding this comment.
As Categorical is somewhat the ndarray with category dtype, this seems a bit like doing
df.astype(np.ndarray)
which seems strange.
But I actually tried this, and this also does not fail but converts all values to object. Is this intended? Or also a bug/case that should raise?
There was a problem hiding this comment.
we could raise and and technically we should as Categorical is NOT a dtype
ok will switch back as it is really stretching the API
jreback
force-pushed
the
to_cat
branch
2 times, most recently
from
99de43a
to
44a0f48
Compare
BUG: Categorical not created properly with to_frame() from Series (GH8626) BUG: handle astype with passed pd.Categorical (GH8626)
jreback
added a commit
that referenced
this pull request
Oct 28, 2014
BUG: various categorical fixes (GH8626)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: coerce Categorical in record array creation (GH8626)
BUG: Categorical not created properly with to_frame() from Series (GH8626)
BUG: handle astype with passed pd.Categorical (GH8626)
closes #8626