Fix enum values not having consistent types (GEA-12685) #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a constant declaration such as the following:
const (
First byte = 1
Second = 2
)
the constant `Second` does not have the same type as the constant
`First`. Enums with explicit values need to have the type present on
each value. This was already the case for some of the SDK's enums but
not all of them, so this patch fixes that.
kenany
force-pushed
the
kenany/GEA-12685
branch
from
028fcb0
to
66677c2
Compare
pangea-andrest
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a constant declaration such as the following:
the constant
Seconddoes not have the same type as the constantFirst. Enums with explicit values need to have the type present on each value. This was already the case for some of the SDK's enums but not all of them, so this patch fixes that.