-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid 2 graphs in memory, sample decompressed blocks, parallelize path embedding #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreaGuarracino
changed the title
Avoid 2 graphs in memory
Avoid 2 graphs in memory and loading all decompressed blocks
Aug 16, 2023
🐸 |
Loading part of the blocks in memory (by sampling them) allows working on very complex graphs with a reasonable amount of RAM. |
AndreaGuarracino
changed the title
Avoid 2 graphs in memory and loading all decompressed blocks
Avoid 2 graphs in memory, sample decompressed blocks, parallelize path embedding
Aug 19, 2023
Path fragments embedding now works in parallel. This should tackle pangenome/pggb#298. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the smoothing and lacing steps in order to avoid keeping both graphs (input one and smoothed one) in memory at the same time.
On small/medium 'normal' graphs, it saves a few gigabytes in the memory peak. Hoping to measure much more savings with other tests with more complex/big graphs.