-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FilePattern.file_type
#322
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fd4e912
implement FilePattern.file_type
cisaacstern 154fa6a
add descriptive file_type/engine errors
cisaacstern 7608233
add deprecation warning for is_opendap
cisaacstern 3037296
pruning logic requires args and attrs to match
cisaacstern 53a6b0b
add test_setting_file_types
cisaacstern 8d16406
tutorial notebook fixes
cisaacstern 6a40fc1
add kerchunk to upstream dev
cisaacstern d61581f
mv OPENER_MAP to xarray_zarr.py
cisaacstern 17f47d8
use regex matching for test_setting_file_types error
cisaacstern fd2ff55
merge upstream
cisaacstern ced6ff4
add release notes for .file_type attr
cisaacstern File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
4,526 changes: 3,795 additions & 731 deletions
4,526
docs/tutorials/xarray_zarr/netcdf_zarr_sequential.ipynb
Large diffs are not rendered by default.
Oops, something went wrong.
2,120 changes: 1,064 additions & 1,056 deletions
2,120
docs/tutorials/xarray_zarr/opendap_subset_recipe.ipynb
Large diffs are not rendered by default.
Oops, something went wrong.
12,899 changes: 10,386 additions & 2,513 deletions
12,899
docs/tutorials/xarray_zarr/terraclimate.ipynb
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we wanted to be nice to our users, we would not just remove this but deprecate it. Now that we have a few users, do we want to be more conservative about breaking changes? Or do we just want to move fast and not worry about that.