Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug of the return value of conn.WriteTo #344

Merged
merged 1 commit into from
Mar 13, 2022
Merged

fix the bug of the return value of conn.WriteTo #344

merged 1 commit into from
Mar 13, 2022

Conversation

JemmyH
Copy link
Contributor

@JemmyH JemmyH commented Mar 13, 2022

Change-Id: I04c0e0b0d4ef9502195b38a545f04c9f1bc305af


name: Pull request
about: Bug fix
title: 'fix the bug of the return value of conn.WriteTo'
labels: ''
assignees: ''

1. Are you opening this pull request for bug-fixes, optimizations or new feature?

bug-fixs

2. Please describe how these code changes achieve your intention.

conn.WriteTo should return the number of bytes actually written

3. Please link to the relevant issues (if any).

#343

4. Which documentation changes (if any) need to be made/updated because of this PR?

connection.go

4. Checklist

  • I have squashed all insignificant commits.
  • I have commented my code for explaining package types, values, functions, and non-obvious lines.
  • I have written unit tests and verified that all tests passes (if needed).
  • I have documented feature info on the README (only when this PR is adding a new feature).
  • (optional) I am willing to help maintain this change if there are issues with it later.

Change-Id: I04c0e0b0d4ef9502195b38a545f04c9f1bc305af
@panjf2000 panjf2000 added the pending merged This PR has been reviewed and approved label Mar 13, 2022
@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #344 (da19a3a) into dev (27667f3) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #344   +/-   ##
=======================================
  Coverage   72.16%   72.16%           
=======================================
  Files          13       13           
  Lines        1376     1376           
=======================================
  Hits          993      993           
  Misses        315      315           
  Partials       68       68           
Flag Coverage Δ
unittests 72.16% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
connection.go 69.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27667f3...da19a3a. Read the comment docs.

@panjf2000 panjf2000 merged commit c9605fc into panjf2000:dev Mar 13, 2022
@panjf2000
Copy link
Owner

Thanks~

0-haha pushed a commit to 0-haha/gnet that referenced this pull request Jan 25, 2023
…2000#344)

Fixes panjf2000#343 

Co-authored-by: hujiaming.0927 <hujiaming.0927@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending merged This PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants