Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: enable ET mode on listener event-loop by default #585

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Conversation

panjf2000
Copy link
Owner

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Apr 21, 2024
@panjf2000 panjf2000 added optimization Some small optimizations performance labels Apr 21, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 79.47%. Comparing base (4033b47) to head (22f4be1).
Report is 1 commits behind head on dev.

Files Patch % Lines
acceptor_unix.go 46.15% 11 Missing and 3 partials ⚠️
engine_unix.go 0.00% 0 Missing and 1 partial ⚠️
eventloop_unix.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #585      +/-   ##
==========================================
+ Coverage   79.08%   79.47%   +0.39%     
==========================================
  Files          25       25              
  Lines        2252     2295      +43     
==========================================
+ Hits         1781     1824      +43     
  Misses        325      325              
  Partials      146      146              
Flag Coverage Δ
unittests 79.47% <42.85%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit 050672f into dev Apr 21, 2024
33 of 34 checks passed
@panjf2000 panjf2000 deleted the listener-et branch April 21, 2024 12:36
leslie-fei pushed a commit to leslie-fei/gnet that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Some small optimizations performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant