Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: reduce duplicate code for I/O reactors #590

Merged
merged 1 commit into from
Apr 23, 2024
Merged

opt: reduce duplicate code for I/O reactors #590

merged 1 commit into from
Apr 23, 2024

Conversation

panjf2000
Copy link
Owner

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Apr 23, 2024
@panjf2000 panjf2000 added the optimization Some small optimizations label Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.50%. Comparing base (5cca785) to head (a5bc95b).

Files Patch % Lines
reactor_default.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #590      +/-   ##
==========================================
- Coverage   79.76%   79.50%   -0.26%     
==========================================
  Files          23       21       -2     
  Lines        2184     2098      -86     
==========================================
- Hits         1742     1668      -74     
+ Misses        302      296       -6     
+ Partials      140      134       -6     
Flag Coverage Δ
unittests 79.50% <50.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit e800fbd into dev Apr 23, 2024
33 of 35 checks passed
@panjf2000 panjf2000 deleted the poller-opt branch April 23, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Some small optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant