Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix Conn.Next and Conn.Peek panic On Unix #616

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

serious-snow
Copy link
Contributor

@serious-snow serious-snow commented Jun 22, 2024

1. Are you opening this pull request for bug-fixes, optimizations or new feature?

bug-fixes

2. Please describe how these code changes achieve your intention.

The code was modified at the suggestion of the author。

3. Please link to the relevant issues (if any).

#615

4. Which documentation changes (if any) need to be made/updated because of this PR?

nothing

4. Checklist

  • I have squashed all insignificant commits.
  • I have commented my code for explaining package types, values, functions, and non-obvious lines.
  • I have written unit tests and verified that all tests passes (if needed).
  • I have documented feature info on the README (only when this PR is adding a new feature).
  • (optional) I am willing to help maintain this change if there are issues with it later.

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.43%. Comparing base (5346527) to head (6269155).

Files Patch % Lines
connection_unix.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #616      +/-   ##
==========================================
- Coverage   79.58%   79.43%   -0.15%     
==========================================
  Files          21       21              
  Lines        2106     2106              
==========================================
- Hits         1676     1673       -3     
- Misses        298      300       +2     
- Partials      132      133       +1     
Flag Coverage Δ
unittests 79.43% <25.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@panjf2000 panjf2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@panjf2000 panjf2000 added bug Something isn't working patch Release patch version labels Jun 22, 2024
@panjf2000 panjf2000 merged commit 36df9ef into panjf2000:dev Jun 22, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Release patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants