BugFix - GCP serviceusage.apiKeys.create Privilege Escalation (#66) #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Checking log keypath existence when using Expressions * BugFix - GCP serviceusage.apiKeys.create Privilege Escalation
darwayne
previously approved these changes
Feb 7, 2024
darwayne
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In the rules where
Expressionsis used in detection logic, it causes errors if the logs don't have the keypath that should be checked withExpressions. Also, given that the UI can't currently render expressions, for now it is better to write rules without usingExpressionsChanges
ExpressionsTesting
pipenv run panther_analysis_tool test --path rules/gcp_audit_rules/ --filter RuleID="GCP.serviceusage.apiKeys.create.Privilege.Escalation"