Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for base64 encoded arguments #1295

Merged
merged 9 commits into from
Jul 23, 2024
Merged

bugfix for base64 encoded arguments #1295

merged 9 commits into from
Jul 23, 2024

Conversation

arielkr256
Copy link
Contributor

@arielkr256 arielkr256 commented Jul 22, 2024

Background

is_base64 was generating some false positives for non-base64 strings

Changes

Testing

  • make test

@arielkr256 arielkr256 marked this pull request as ready for review July 22, 2024 15:49
@arielkr256 arielkr256 requested a review from a team as a code owner July 22, 2024 15:49
Copy link

😱
looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml

@arielkr256 arielkr256 marked this pull request as draft July 22, 2024 16:27
@arielkr256 arielkr256 marked this pull request as ready for review July 22, 2024 16:44
@arielkr256 arielkr256 marked this pull request as draft July 22, 2024 16:51
@arielkr256 arielkr256 marked this pull request as ready for review July 22, 2024 19:28
@arielkr256 arielkr256 enabled auto-merge (squash) July 23, 2024 15:01
Copy link
Contributor

@ben-githubs ben-githubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arielkr256 arielkr256 merged commit 990bbe3 into release Jul 23, 2024
6 checks passed
@arielkr256 arielkr256 deleted the base64-validate branch July 23, 2024 15:03
@arielkr256 arielkr256 added the bug Something isn't working label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants