Fix methodName lookups for Cloud Run rules, add tests #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial cloud run correlation rules throw NoneType errors on every GCP.AuditLog that has no event.methodName because of a `deep_get()` without a `default`. One was fixed in a recent PR panther-labs#1292, the other wasn't. Here's the same fix for both and tests to prove them.
|
We just merged a PR yesterday for the same issue, but we only fixed |
ben-githubs
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This unsafe lookup is triggering
AttributeError("'NoneType' object has no attribute 'endswith'")every GCP.AuditLog event that has noevent.methodNameChanges
deep_get()Testing
event.methodNameincluded for both.