Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity JSON object to Slack Privilege Escalation tests #1300

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

bmbeverst
Copy link
Contributor

Background

Noticed that the move from JSON to YAML had caused the addition of the entity block to be missed. The tests therefore show unknown-actor and unknown-email. This does not impact the functionality issue but could lead to confusion.

Slack.AuditLogs.UserPrivilegeEscalation
	[PASS] Permissions Assigned
		[PASS] [rule] true
		[PASS] [title] Slack User Assigned Permissions <unknown-actor> (<unknown-email>)
		[PASS] [dedup] Slack User Assigned Permissions <unknown-actor> (<unknown-email>)
		[PASS] [alertContext] {"actor-name": "username", "actor-email": "user@example.com", "actor-ip": "1.2.3.4", "user-agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.0.0 Safari/537.36"}
		[PASS] [severity] MEDIUM

	[PASS] Role Changed to Admin
		[PASS] [rule] true
		[PASS] [title] Slack User Made Admin <unknown-actor> (<unknown-email>)
		[PASS] [dedup] Slack User Made Admin <unknown-actor> (<unknown-email>)
		[PASS] [alertContext] {"actor-name": "username", "actor-email": "user@example.com", "actor-ip": "1.2.3.4", "user-agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.0.0 Safari/537.36"}
		[PASS] [severity] CRITICAL

	[PASS] Role Changed to Owner
		[PASS] [rule] true
		[PASS] [title] Slack User Made Owner <unknown-actor> (<unknown-email>)
		[PASS] [dedup] Slack User Made Owner <unknown-actor> (<unknown-email>)
		[PASS] [alertContext] {"actor-name": "username", "actor-email": "user@example.com", "actor-ip": "1.2.3.4", "user-agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.0.0 Safari/537.36"}
		[PASS] [severity] CRITICALunrestricted

Changes

  • Added the entity block in test JSON.

Testing

  • pipenv run panther_analysis_tool test --skip-disabled-tests --sort-test-results
Slack.AuditLogs.UserPrivilegeEscalation
	[PASS] Permissions Assigned
		[PASS] [rule] true
		[PASS] [title] Slack User Assigned Permissions primary-owner (user@example.com)
		[PASS] [dedup] Slack User Assigned Permissions primary-owner (user@example.com)
		[PASS] [alertContext] {"actor-name": "username", "actor-email": "user@example.com", "actor-ip": "1.2.3.4", "user-agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.0.0 Safari/537.36"}
		[PASS] [severity] MEDIUM

	[PASS] Role Changed to Admin
		[PASS] [rule] true
		[PASS] [title] Slack User Made Admin primary-owner (user@example.com)
		[PASS] [dedup] Slack User Made Admin primary-owner (user@example.com)
		[PASS] [alertContext] {"actor-name": "username", "actor-email": "user@example.com", "actor-ip": "1.2.3.4", "user-agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.0.0 Safari/537.36"}
		[PASS] [severity] CRITICAL

	[PASS] Role Changed to Owner
		[PASS] [rule] true
		[PASS] [title] Slack User Made Owner primary-owner (user@example.com)
		[PASS] [dedup] Slack User Made Owner primary-owner (user@example.com)
		[PASS] [alertContext] {"actor-name": "username", "actor-email": "user@example.com", "actor-ip": "1.2.3.4", "user-agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.0.0 Safari/537.36"}
		[PASS] [severity] CRITICAL

@bmbeverst bmbeverst requested a review from a team as a code owner July 24, 2024 15:22
Copy link
Contributor

@ben-githubs ben-githubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for fixing this!

@ben-githubs ben-githubs merged commit 7f1a0ab into panther-labs:release Jul 24, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants