Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v3.62.0 #1338

Merged
merged 49 commits into from
Aug 27, 2024
Merged

Prepare for v3.62.0 #1338

merged 49 commits into from
Aug 27, 2024

Conversation

arielkr256
Copy link
Contributor

Background

PR to prepare this week's release.

Changes

  • Aggregates the PRs that will be included in this week's release

Testing

  • N/A

ben-githubs and others added 30 commits July 22, 2024 14:48
### Background

The original `Github.Repo.HookModified` rule is inappropriately named and had some errors in its tests. The `hook.*` audit log events capture any webhook event that occurs [in a repository, organization, GitHub Marketplace account, GitHub Sponsors account, or GitHub App](https://docs.github.com/en/webhooks/using-webhooks/creating-webhooks#:~:text=in%20a%20repository%2C%20organization%2C%20GitHub%20Marketplace%20account%2C%20GitHub%20Sponsors%20account%2C%20or%20GitHub%20App). The rule initially was designed to capture any webhook modification but labelled and titled as repo-specific.

This corrects the minor error with a appropriately named rule, fixes the tests, and improves the alert title. The core logic remains the same.

### Changes

- Disable GitHub.Repo.HookModified, remove from packs
- Replicate original rule and create GitHub.Webhook.Modified, add to packs
- Enhances alert context and improves title
- Fix previous tests using incorrect field names, add test for GitHub App webhook

### Testing

pat test, make lint
…nrouted

Info Alerts are Signals, Nonrouted
…dit_rules

New Rules: CS EventStream Audit Events
* updated okta rate limit rules

* only alert on rate limit violations

---------

Co-authored-by: ben-githubs <38414634+ben-githubs@users.noreply.github.com>
Co-authored-by: ben-githubs <38414634+ben-githubs@users.noreply.github.com>
Co-authored-by: ben-githubs <38414634+ben-githubs@users.noreply.github.com>
ben-githubs and others added 18 commits August 21, 2024 11:45
* added missing MITRE ATT&CK tactics to the rules

* updated mitre tactics

* fix duplicate key

* updated the MITRE mappings for the CS Event Stream rules

---------

Co-authored-by: Ben Airey <benjaminjohnairey@gmail.com>
* tuning Wiz Alert Passthrough rule

* update dedup

* comment unused code

---------

Co-authored-by: ben-githubs <38414634+ben-githubs@users.noreply.github.com>
…dified-rule

Improve GitHub Webhook Modified rule
…Trail.SnapshotMadePublic

Add Dynamic Severity to AWS.CloudTrail.SnapshotMadePublic
…anther-tests

Fix Unit Tests Failing in Pypanther
…etection-tuning

THREAT 371: Slack Anomaly Detection Tuning
@arielkr256 arielkr256 requested a review from a team as a code owner August 27, 2024 16:09
Copy link

😱
looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml

@arielkr256 arielkr256 merged commit 428e614 into main Aug 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants