-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for v3.62.0
#1338
Merged
Merged
Prepare for v3.62.0
#1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Background The original `Github.Repo.HookModified` rule is inappropriately named and had some errors in its tests. The `hook.*` audit log events capture any webhook event that occurs [in a repository, organization, GitHub Marketplace account, GitHub Sponsors account, or GitHub App](https://docs.github.com/en/webhooks/using-webhooks/creating-webhooks#:~:text=in%20a%20repository%2C%20organization%2C%20GitHub%20Marketplace%20account%2C%20GitHub%20Sponsors%20account%2C%20or%20GitHub%20App). The rule initially was designed to capture any webhook modification but labelled and titled as repo-specific. This corrects the minor error with a appropriately named rule, fixes the tests, and improves the alert title. The core logic remains the same. ### Changes - Disable GitHub.Repo.HookModified, remove from packs - Replicate original rule and create GitHub.Webhook.Modified, add to packs - Enhances alert context and improves title - Fix previous tests using incorrect field names, add test for GitHub App webhook ### Testing pat test, make lint
Remove deprecated IOC helpers
…nrouted Info Alerts are Signals, Nonrouted
…dit_rules New Rules: CS EventStream Audit Events
* updated okta rate limit rules * only alert on rate limit violations --------- Co-authored-by: ben-githubs <38414634+ben-githubs@users.noreply.github.com>
Co-authored-by: ben-githubs <38414634+ben-githubs@users.noreply.github.com>
Co-authored-by: ben-githubs <38414634+ben-githubs@users.noreply.github.com>
* added missing MITRE ATT&CK tactics to the rules * updated mitre tactics * fix duplicate key * updated the MITRE mappings for the CS Event Stream rules --------- Co-authored-by: Ben Airey <benjaminjohnairey@gmail.com>
* tuning Wiz Alert Passthrough rule * update dedup * comment unused code --------- Co-authored-by: ben-githubs <38414634+ben-githubs@users.noreply.github.com>
…dified-rule Improve GitHub Webhook Modified rule
…Trail.SnapshotMadePublic Add Dynamic Severity to AWS.CloudTrail.SnapshotMadePublic
…anther-tests Fix Unit Tests Failing in Pypanther
Convert to Signals
…etection-tuning THREAT 371: Slack Anomaly Detection Tuning
PAT update v0.52.1
😱 [INFO][root]: ignoring file dependabot.yml |
le4ker
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
PR to prepare this week's release.
Changes
Testing