Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS SAML Activity Tuning #1341

Merged
merged 2 commits into from
Sep 4, 2024
Merged

AWS SAML Activity Tuning #1341

merged 2 commits into from
Sep 4, 2024

Conversation

arielkr256
Copy link
Contributor

Background

Automated tools can attempt to delete SAML providers multiple times, causing false positives.

Changes

  • Only alert when no errorCode is present in the log

Testing

  • pat test

@arielkr256 arielkr256 requested a review from a team as a code owner September 3, 2024 18:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

😱
looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml

@arielkr256 arielkr256 merged commit 41e993b into release Sep 4, 2024
6 checks passed
@arielkr256 arielkr256 deleted the aws-saml-tuning branch September 4, 2024 15:36
@arielkr256 arielkr256 added the tuning detection tuning label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le4ker le4ker le4ker approved these changes

Assignees
No one assigned
Labels
tuning detection tuning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arielkr256 @le4ker @ben-githubs