Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 466: Add mock to rule test #1364

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix issue 466: Add mock to rule test #1364

merged 1 commit into from
Sep 25, 2024

Conversation

arielkr256
Copy link
Contributor

Background

Fixes #466

Changes

  • Adds a mock to the invalid rule test
  • Removes hardcoded example ALLOW_LIST

Testing

  • make test

@arielkr256 arielkr256 requested a review from a team as a code owner September 25, 2024 19:26
@arielkr256 arielkr256 enabled auto-merge (squash) September 25, 2024 19:27
@github-actions GitHub Actions
Copy link

😱
looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml

@arielkr256 arielkr256 added the bug Something isn't working label Sep 25, 2024
@arielkr256 arielkr256 merged commit 0582195 into release Sep 25, 2024
8 checks passed
@arielkr256 arielkr256 deleted the fix-issue-466 branch September 25, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-githubs ben-githubs ben-githubs approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid test case
2 participants
@arielkr256 @ben-githubs