Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1367: Reformat YAML to Always Use Literal Block for Query Text #1370

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

ben-githubs
Copy link
Contributor

@ben-githubs ben-githubs commented Sep 27, 2024

Background

#1367 raised the problem that using a folded block (>) when denoting SQL code in our YAML files can cause issues for some YAML parsers, since > allows the parser to insert line breaks where it find convenient, potentially breaking certain parts of the query. By using the literal block |, we ensure parsers maintain the current formatting of the SQL code.

Changes

  • change all SQL query blocks from folded > block style to literal | block style.

Testing

  • Linting passes, and a test upload found no problems.

@ben-githubs ben-githubs requested a review from a team as a code owner September 27, 2024 21:13
Copy link

😱
looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml

@arielkr256 arielkr256 added bug Something isn't working queries Stored Queries that help to quickly investigate labels Sep 30, 2024
@arielkr256 arielkr256 linked an issue Sep 30, 2024 that may be closed by this pull request
@arielkr256 arielkr256 enabled auto-merge (squash) September 30, 2024 15:00
@arielkr256 arielkr256 merged commit 79a1ff9 into release Sep 30, 2024
8 checks passed
@arielkr256 arielkr256 deleted the issue-1367 branch September 30, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working queries Stored Queries that help to quickly investigate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect YAML block style causes corruption during load/dump
2 participants