Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete 'Snowflake.PublicRoleGrant' & query #1386

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

ben-githubs
Copy link
Contributor

Background

Customers realized this query alerts on any permission grant on a table in the public schema, which happens a lot. The rule will be replaced soon by a streaming version, so we're removing this noisy version.

Changes

  • removed Snowflake.PublicRoleGrant
  • removed Query.Snowflake.PublicRoleGrant

Testing

  • make check-deprecated passes

@ben-githubs ben-githubs requested a review from a team as a code owner October 11, 2024 19:21
@arielkr256 arielkr256 added tuning detection tuning queries Stored Queries that help to quickly investigate scheduled_rules Scheduled rules pair Queries with Rules for query based detections packs New Packs and Expansion of Existing Packs labels Oct 15, 2024
@arielkr256 arielkr256 enabled auto-merge (squash) October 15, 2024 03:23
Copy link

😱
looks like some things could be wrong with the packs

@arielkr256 arielkr256 merged commit 8e7a6f6 into develop Oct 15, 2024
9 checks passed
@arielkr256 arielkr256 deleted the ben/deprecate-snowflake-public-grant-rule branch October 15, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packs New Packs and Expansion of Existing Packs queries Stored Queries that help to quickly investigate scheduled_rules Scheduled rules pair Queries with Rules for query based detections tuning detection tuning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants