Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Standard.SignInFromRogueState for Unenriched Events #1431

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix Standard.SignInFromRogueState for Unenriched Events #1431

merged 1 commit into from
Nov 13, 2024

Conversation

ben-githubs
Copy link
Contributor

Background

An oversight in the rule caused it to error if there wasn't a p_enrichment value for IPInfo location.

Changes

  • Added logic to gracefully return false if we can't find a matching country in pycountry for some reason, including due to the enrichment data being absent

Testing

  • added unit test for missing enrichment data
  • added unit test for enrichment data referencing an unknown country code

@ben-githubs ben-githubs requested a review from a team as a code owner November 13, 2024 16:24
@github-actions GitHub Actions
Copy link

😱
looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml

@arielkr256 arielkr256 added the bug Something isn't working label Nov 13, 2024
@arielkr256 arielkr256 enabled auto-merge (squash) November 13, 2024 18:51
@arielkr256 arielkr256 merged commit 9098060 into develop Nov 13, 2024
8 checks passed
@arielkr256 arielkr256 deleted the ben/fix-standard-signin-rogue-state branch November 13, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielkr256 arielkr256 arielkr256 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-githubs @arielkr256