Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiz.Alert.Passthrough: New Dedup Logic #1438

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

ben-githubs
Copy link
Contributor

Background

We've observed large numbers of low-level alerts for some customers, due to a handful of Wiz rules failing for a large number of resources. The current dedup behaviour of the Panther rule is to group based on the resource ID. This PR alters the behaviour to dedup low-level alerts based on the Wiz rule ID instead, ensuring that low-severity policies that fail against many resources don't generate alert storms.

This should be more useful to Panther customers as well, since they get 1 alert informing them that many resources have failed the policy.

Simulations testing this against alert metadata from several volunteering customers say alert reductions between 10%-50%

Changes

  • add alternative dedup logic for low-severity Wiz alerts to group based on the Rule ID instead of the Resource ID

Testing

  • tested an alert simulation using new dedup logic
  • dedup string output for unit tests matches expected value

@ben-githubs ben-githubs requested a review from a team as a code owner December 2, 2024 17:29
@arielkr256 arielkr256 added rules Real-time log data detections tuning detection tuning labels Dec 2, 2024
Copy link
Contributor

@arielkr256 arielkr256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arielkr256 arielkr256 enabled auto-merge (squash) December 2, 2024 20:19
@arielkr256 arielkr256 merged commit f1eee0c into develop Dec 2, 2024
8 checks passed
@arielkr256 arielkr256 deleted the THREAT-409/wiz-alert-passthrough-tuning branch December 2, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rules Real-time log data detections tuning detection tuning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants