Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Snowflake.Stream.AttemptedLoginByDisabledUser and assc. query #1444

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

ben-githubs
Copy link
Contributor

@ben-githubs ben-githubs commented Dec 9, 2024

Background

This query relies on a Snowflake table that actually doesn't exist in the finalized production version of the Snowflake log puller. Customers have encountered issues enabling this query, due to the underlying table not existing, and since it never will, we decided to remove the query (and rule) entirely.

Follows From: ASK-1078

Changes

  • remove rule Snowflake.Stream.AttemptedLoginByDisabledUser
  • remove query Snowflake Attempted Login With Disabled User

Testing

  • all other unit tests still pass
  • removed items were added to deprecated.txt
  • pack was updated

@ben-githubs ben-githubs requested a review from a team as a code owner December 9, 2024 16:57
@ben-githubs ben-githubs added the bug Something isn't working label Dec 9, 2024
@arielkr256 arielkr256 merged commit f8f7890 into develop Dec 9, 2024
7 of 8 checks passed
@arielkr256 arielkr256 deleted the ben/remove-snowflake-users-query branch December 9, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants