May Update: S3 Rules #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacknagz
requested review from
austinbyers,
kostaspap and
nhakmiller
as code owners
nhakmiller
approved these changes
May 14, 2020
| # IP addresses (in CIDR notation) indicating approved IP ranges for accessing S3 buckets | ||
| IP_WHITELIST = { | ||
| BUCKET_NAMES = { | ||
| # Example bucket names go here |
There was a problem hiding this comment.
Should this comment say something like "restricted bucket names go here" or something?
| ip_network('10.0.0.0/8'), | ||
| } | ||
|
|
||
|
|
||
| def rule(event): | ||
| # Only evaluate if the remoteIP field is present | ||
| if BUCKET_NAMES: |
There was a problem hiding this comment.
Is the intent that if BUCKET_NAMES is empty, it applies to all buckets? Perhaps a comment should clarify that under the BUCKET_NAMES declaration at the top.
There was a problem hiding this comment.
The intention is that if it's empty, we just apply to all buckets
melenevskyi
pushed a commit
that referenced
this pull request
Dec 12, 2023
* adding special handling of SchemaWrongKeyError exceptions * format update; added unit test to check new method * fixing bad merge
egibs
pushed a commit
that referenced
this pull request
Jan 30, 2024
risto-liftoff
added a commit
to risto-liftoff/panther-analysis
that referenced
this pull request
Feb 29, 2024
sync this fork to panther-labs/panther-analysis v3.16.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
A general audit and refresh of our S3 access log rules
Changes
Testing
Locally: