Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #246
This pull request consists of three commits.
The first commit adds the following method to
Parser
and use it in theparse_expression
method with two arguments.std::shared_ptr<ExpressionNode> parse_expression(Template& tmpl)
The method with one argument returns when unexpected token is found.
The second fixes
function(num1 + num2, num3)
seems to run as if it isfunction(num1, num2 + num3)
#246.parse_expression
with one argument is called recursively for each argument.The third is optional. If you don't prefer it, I'll revert it. It calls
parse_expression
with one argument after a left parenthesis instead of counting the nested level bycurrent_paren_level
.