-
-
Notifications
You must be signed in to change notification settings - Fork 643
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't WARN when a spec matches no relevant targets.
This warning has its uses (e.g., if you accidentally ran on the wrong target), but on balance, with hindsight, it seems more distracting and confusing than useful. This is especially true with glob specs: "Run all the tests under foo/::" can be satisfied vacuously if there are no tests under foo/::, so it's weird to issue a warning. In such cases we should adhere to the principle that "the empty set is not a special case", and just let things hold vacuously. Of course we can still ERROR when a goal absolutely needs a target in order to make any sense at all. [ci skip-rust] [ci skip-build-wheels]
- Loading branch information
Showing
4 changed files
with
1 addition
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters