Skip to content

Commit

Permalink
Add annotation to untyped function causing mypy note (#21611)
Browse files Browse the repository at this point in the history
Running `pants check ::` currently gets a `note` level warning from
mypy. This PR fixes it.

```
src/python/pants/core/util_rules/external_tool_test.py: note: In function "test_export":
src/python/pants/core/util_rules/external_tool_test.py:194:5: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
src/python/pants/core/util_rules/external_tool_test.py:215:5: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
```

This appears to be caused by a minor oversight in a test in #21258
(missing the `-> None`).
  • Loading branch information
huonw authored Nov 11, 2024
1 parent 34f113a commit 89e8819
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/python/pants/core/util_rules/external_tool_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def rule_runner():
)


def test_export(rule_runner):
def test_export(rule_runner) -> None:
"""Tests export_external_tool.
Ensures we locate the class and prepare the Digest correctly
Expand Down

0 comments on commit 89e8819

Please sign in to comment.