Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duration and cache source to fmt/lint/check output. #14066

Open
asherf opened this issue Jan 4, 2022 · 2 comments
Open

Add duration and cache source to fmt/lint/check output. #14066

asherf opened this issue Jan 4, 2022 · 2 comments

Comments

@asherf
Copy link
Member

asherf commented Jan 4, 2022

Similar to how this was implemented for tests: #13889
I think we should have it for other goals, for the pants project, I think it is a huge flex to show that it didn't need to run a specific task since the input didn't change.

@stuhood
Copy link
Member

stuhood commented Jan 4, 2022

Possibly! One bit of complexity here is just that the "scope" of fmt/lint/check is still being discussed and will likely be adjusted in #13462 and others. So "how many files were checked/formatted/linted and in how many processes" isn't always as clear as it is for tests (where it is always "a target in one process": usually a single file).

@thejcannon
Copy link
Member

+1 to the duration. I'm seeing pylint being a particular tentpole in my repo but I couldn't give you more specific timings without some clever wiring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants