Add duration and cache source to test output. #13889

riisi · 2021-12-15T19:34:26Z

[ci skip-rust]
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

src/python/pants/core/goals/test.py

src/python/pants/core/goals/test_test.py

benjyw · 2021-12-20T04:38:52Z

@riisi Thanks for this contribution! I think a lot of users will love this, and it helps demonstrate one of the major benefits of Pants.

stuhood

Thanks a lot @riisi! This looks great.

stuhood · 2021-12-20T15:50:59Z

src/python/pants/backend/go/goals/test.py

+            # TODO: What should be here?
+            result_metadata=ProcessResultMetadata(None, "", 0),


Good question. I think that:

this case of failed compilation (where the test process didn't even start)

the case of a skipped test (TestResult.skip)

...could maybe both be joined into an explicit yellow "was skipped" state for the test. For now, it seems simple enough to make the result_metadata optional (result_metadata: ProcessResultMetadata | None), and to then render the skipped sigil for tests with no metadata:

pants/src/python/pants/core/goals/lint.py

Lines 242 to 244 in 7e65826

if results.skipped:

sigil = console.sigil_skipped()

status = "skipped"

I wasn't sure how to replicate skipped tests for Python. I think in the case of using pytest.mark.skip to skip a module, then pytest exits with non-0 code - I think this has been discussed in Slack before.
Haven't tested failed compilation yet.

src/python/pants/core/goals/test.py

src/python/pants/core/goals/test_test.py

src/python/pants/core/goals/test.py

riisi · 2021-12-24T10:00:37Z

Thanks for this @stuhood. I'll start taking a look now - internet access maybe a bit restricted over holiday period though.

Co-authored-by: Stu Hood <stuhood@gmail.com>

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

riisi · 2021-12-24T13:49:50Z

Some mypy issues to fix - can look into this further. Pushed what I have for now.

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

stuhood · 2021-12-27T19:47:20Z

Some mypy issues to fix - can look into this further. Pushed what I have for now.

I've fixed the typing issues, and added output support for skipped tests.

Thanks a lot for the contribution!

Eric-Arellano

Sweet! Thanks!

Fixes pantsbuild#13588. [ci skip-rust] [ci skip-build-wheels]

…14002) Fixes #13588. [ci skip-rust] [ci skip-build-wheels]

riisi · 2021-12-28T07:58:25Z

Thanks @stuhood ! 👏

…call to _format_test_summary follow up for pantsbuild#13889

…call to _format_test_summary (#14019) instead of on every call to _format_test_summary follow up for #13889

Add duration and cache source to test output.

b344635

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

riisi commented Dec 15, 2021

View reviewed changes

src/python/pants/core/goals/test.py Outdated Show resolved Hide resolved

riisi commented Dec 15, 2021

View reviewed changes

src/python/pants/core/goals/test_test.py Outdated Show resolved Hide resolved

stuhood requested review from Eric-Arellano, stuhood and benjyw December 16, 2021 16:53

stuhood reviewed Dec 20, 2021

View reviewed changes

riisi and others added 2 commits December 24, 2021 10:26

Update src/python/pants/core/goals/test.py

189bb6c

Co-authored-by: Stu Hood <stuhood@gmail.com>

Address PR comments

54e1d60

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

Add support for skipped tests, and fix up test harness.

c7f11d6

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

stuhood enabled auto-merge (squash) December 27, 2021 19:47

Eric-Arellano approved these changes Dec 27, 2021

View reviewed changes

stuhood added the needs-cherrypick label Dec 27, 2021

stuhood added this to the 2.9.x milestone Dec 27, 2021

stuhood merged commit fa74bf4 into pantsbuild:main Dec 27, 2021

stuhood pushed a commit to stuhood/pants that referenced this pull request Dec 27, 2021

Add duration and cache source to test output. (pantsbuild#13889)

b29eb8b

Fixes pantsbuild#13588. [ci skip-rust] [ci skip-build-wheels]

stuhood added a commit that referenced this pull request Dec 27, 2021

Add duration and cache source to test output. (cherrypick of #13889) (#…

1d13e78

…14002) Fixes #13588. [ci skip-rust] [ci skip-build-wheels]

stuhood removed the needs-cherrypick label Dec 27, 2021

asherf added a commit to asherf/pants that referenced this pull request Dec 28, 2021

[internal] define process result source map once instead of on every …

6c9b999

…call to _format_test_summary follow up for pantsbuild#13889

asherf mentioned this pull request Dec 28, 2021

[internal] define process result source map once #14019

Merged

Eric-Arellano pushed a commit that referenced this pull request Dec 29, 2021

[internal] define process result source map once instead of on every …

2d1d194

…call to _format_test_summary (#14019) instead of on every call to _format_test_summary follow up for #13889

asherf mentioned this pull request Jan 4, 2022

Add duration and cache source to fmt/lint/check output. #14066

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add duration and cache source to test output. #13889

Add duration and cache source to test output. #13889

riisi commented Dec 15, 2021 •

edited by stuhood

Loading

benjyw commented Dec 20, 2021

stuhood left a comment

stuhood Dec 20, 2021

riisi Dec 24, 2021

riisi commented Dec 24, 2021

riisi commented Dec 24, 2021

stuhood commented Dec 27, 2021

Eric-Arellano left a comment

riisi commented Dec 28, 2021

		# TODO: What should be here?
		result_metadata=ProcessResultMetadata(None, "", 0),

	if results.skipped:
	sigil = console.sigil_skipped()
	status = "skipped"

Add duration and cache source to test output. #13889

Add duration and cache source to test output. #13889

Conversation

riisi commented Dec 15, 2021 • edited by stuhood Loading

benjyw commented Dec 20, 2021

stuhood left a comment

Choose a reason for hiding this comment

stuhood Dec 20, 2021

Choose a reason for hiding this comment

riisi Dec 24, 2021

Choose a reason for hiding this comment

riisi commented Dec 24, 2021

riisi commented Dec 24, 2021

stuhood commented Dec 27, 2021

Eric-Arellano left a comment

Choose a reason for hiding this comment

riisi commented Dec 28, 2021

riisi commented Dec 15, 2021 •

edited by stuhood

Loading