Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecation warning on Python 3.10 #17551

Closed
tdyas opened this issue Nov 15, 2022 · 2 comments · Fixed by #17552
Closed

deprecation warning on Python 3.10 #17551

tdyas opened this issue Nov 15, 2022 · 2 comments · Fixed by #17552
Assignees
@Eric-Arellano

Comments

@tdyas
Copy link
Contributor

tdyas commented Nov 15, 2022

On latest main with Python 3.10.7:

11:07:09.96 [WARN] /REDACTED/pants/src/python/pants/engine/streaming_workunit_handler.py:292: DeprecationWarning: isSet() is deprecated, use is_set() instead
  while not self.stop_request.isSet():
@Eric-Arellano
Copy link
Contributor

Thanks! Given that Pants doesn't release for 3.10, I imagine this is pants_from_sources or running on main in the repo? Why this is relevant is I don't think we need to backport to any Pants release, fortunately.

@Eric-Arellano Eric-Arellano self-assigned this Nov 15, 2022
@tdyas
Copy link
Contributor Author

tdyas commented Nov 15, 2022

On latest main with Python 3.10.7:

@Eric-Arellano Eric-Arellano mentioned this issue Nov 15, 2022
Merged
Eric-Arellano added a commit that referenced this issue Nov 15, 2022
@Eric-Arellano
Fix deprecation message for threading.Event (#17552)
e046d36 
Closes #17551 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eric-Arellano Eric-Arellano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecation message for threading.Event Eric-Arellano/pants
2 participants
@tdyas @Eric-Arellano