Add option for async completion of StreamingWorkunitHandlers, disable by default in containers #12392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and disable it when we are likely running inside a container. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
Eric-Arellano
approved these changes
Jul 21, 2021
asherf
reviewed
Jul 21, 2021
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
approved these changes
Jul 21, 2021
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Jul 22, 2021
… by default in containers (pantsbuild#12392) When run inside of a container that exits as soon as the client returns, async completion of workunit handlers can lead to loss of metrics. Since async completion has significant performance benefits, we disable it conditionally based on whether it is likely that we are running inside of a container. Fixes pantsbuild#11833. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Jul 22, 2021
… by default in containers (pantsbuild#12392) When run inside of a container that exits as soon as the client returns, async completion of workunit handlers can lead to loss of metrics. Since async completion has significant performance benefits, we disable it conditionally based on whether it is likely that we are running inside of a container. Fixes pantsbuild#11833. [ci skip-rust]
Eric-Arellano
pushed a commit
that referenced
this pull request
Jul 22, 2021
… by default in containers (Cherry-pick of #12392) (#12398) When run inside of a container that exits as soon as the client returns, async completion of workunit handlers can lead to loss of metrics. Since async completion has significant performance benefits, we disable it conditionally based on whether it is likely that we are running inside of a container. Fixes #11833. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
pushed a commit
that referenced
this pull request
Jul 22, 2021
… by default in containers (Cherry-pick of #12392) (#12399) When run inside of a container that exits as soon as the client returns, async completion of workunit handlers can lead to loss of metrics. Since async completion has significant performance benefits, we disable it conditionally based on whether it is likely that we are running inside of a container. Fixes #11833. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run inside of a container that exits as soon as the client returns, async completion of workunit handlers can lead to loss of metrics. Since async completion has significant performance benefits, we disable it conditionally based on whether it is likely that we are running inside of a container.
Fixes #11833.
[ci skip-rust]