Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Switch to AWS CLI v2 #14095

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Conversation

asherf
Copy link
Member

@asherf asherf commented Jan 6, 2022

AWS CLI v2 is the recommended way to interact w/ AWS.
see: https://github.com/pantsbuild/pants/runs/4730814987?check_suite_focus=true#step:12:57
Screen Shot 2022-01-06 at 2 04 25 PM

https://docs.aws.amazon.com/cli/latest/userguide/getting-started-install.html

the command in deploy_to_s3.py should work just fine with the new CLI.
see: https://docs.aws.amazon.com/cli/latest/reference/s3/sync.html#synopsis

subprocess.run(
[
"aws",
"s3",
"sync",
# This instructs the sync command to ignore timestamps, which we must do to allow
# distinct shards—which may finish building their wheels at different times—to not
# overwrite otherwise-identical wheels.
"--size-only",
"--acl",
"public-read",
"dist/deploy",
"s3://binaries.pantsbuild.org",

@Eric-Arellano Eric-Arellano merged commit 2ecc826 into pantsbuild:main Jan 6, 2022
Eric-Arellano added a commit to Eric-Arellano/pants that referenced this pull request Jan 7, 2022
This reverts commit 2ecc826.

[ci skip-rust]

[ci skip-build-wheels]
Eric-Arellano pushed a commit that referenced this pull request Jan 7, 2022
@stuhood stuhood mentioned this pull request Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants